]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
Bluetooth: hci_sock: Reset cookie to zero in hci_sock_free_cookie()
authorZijun Hu <zijun.hu@oss.qualcomm.com>
Mon, 23 Jun 2025 12:31:16 +0000 (20:31 +0800)
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Wed, 23 Jul 2025 14:25:34 +0000 (10:25 -0400)
Reset cookie value to 0 instead of 0xffffffff in hci_sock_free_cookie()
since:
0         :  means cookie has not been assigned yet
0xffffffff:  means cookie assignment failure

Also fix generating cookie failure with usage shown below:
hci_sock_gen_cookie(sk)   // generate cookie
hci_sock_free_cookie(sk)  // free cookie
hci_sock_gen_cookie(sk)   // Can't generate cookie any more

Signed-off-by: Zijun Hu <zijun.hu@oss.qualcomm.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
net/bluetooth/hci_sock.c

index 428ee5c7de7ea32fea08a2ebcf57e30dee59e3fa..fc866759910d95f40f159cfd63710f4c5e519dfd 100644 (file)
@@ -118,7 +118,7 @@ static void hci_sock_free_cookie(struct sock *sk)
        int id = hci_pi(sk)->cookie;
 
        if (id) {
-               hci_pi(sk)->cookie = 0xffffffff;
+               hci_pi(sk)->cookie = 0;
                ida_free(&sock_cookie_ida, id);
        }
 }