]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
error-inject: use IS_ERR() check for debugfs_create_file()
authorIngyu Jang <ingyujang25@korea.ac.kr>
Thu, 14 May 2026 19:32:14 +0000 (04:32 +0900)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 29 May 2026 04:24:57 +0000 (21:24 -0700)
debugfs_create_file() returns an error pointer on failure, never NULL, so
the !file check in ei_debugfs_init() never triggers and the
debugfs_remove() cleanup cannot run.

Use IS_ERR() and propagate the actual error via PTR_ERR().

Link: https://lore.kernel.org/20260514193214.2432769-1-ingyujang25@korea.ac.kr
Signed-off-by: Ingyu Jang <ingyujang25@korea.ac.kr>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
lib/error-inject.c

index f3d1b70be605c6cee8af7435046d146cfc9d53e0..32f3d1ca9ea2333a4d32985b41f3a659f40fe44a 100644 (file)
@@ -219,9 +219,9 @@ static int __init ei_debugfs_init(void)
        dir = debugfs_create_dir("error_injection", NULL);
 
        file = debugfs_create_file("list", 0444, dir, NULL, &ei_fops);
-       if (!file) {
+       if (IS_ERR(file)) {
                debugfs_remove(dir);
-               return -ENOMEM;
+               return PTR_ERR(file);
        }
 
        return 0;