]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
counter: interrupt-cnt: use devm_mutex_init()
authorStepan Ionichev <sozdayvek@gmail.com>
Sat, 23 May 2026 18:44:18 +0000 (23:44 +0500)
committerWilliam Breathitt Gray <wbg@kernel.org>
Wed, 27 May 2026 22:13:33 +0000 (07:13 +0900)
interrupt_cnt_probe() calls mutex_init() but neither this driver
nor the counter core issues a matching mutex_destroy() on unbind,
so the lock debug state is leaked.

Switch to devm_mutex_init() so the mutex is torn down in the same
devm scope it was set up in.

Signed-off-by: Stepan Ionichev <sozdayvek@gmail.com>
Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
Link: https://lore.kernel.org/r/20260523184418.7586-1-sozdayvek@gmail.com
Signed-off-by: William Breathitt Gray <wbg@kernel.org>
drivers/counter/interrupt-cnt.c

index e6100b5fb082e0a707c07cfac4806807ad131462..cd475382ab6a5aa761aac454a2702c961ddf7212 100644 (file)
@@ -233,7 +233,9 @@ static int interrupt_cnt_probe(struct platform_device *pdev)
        if (ret)
                return ret;
 
-       mutex_init(&priv->lock);
+       ret = devm_mutex_init(dev, &priv->lock);
+       if (ret)
+               return ret;
 
        ret = devm_counter_add(dev, counter);
        if (ret < 0)