]> git.ipfire.org Git - thirdparty/bugzilla.git/commitdiff
Bug 1111043: Bug.add_comment returns the wrong comment ID
authorFrédéric Buclin <LpSolit@gmail.com>
Wed, 17 Dec 2014 19:42:10 +0000 (20:42 +0100)
committerFrédéric Buclin <LpSolit@gmail.com>
Wed, 17 Dec 2014 19:42:10 +0000 (20:42 +0100)
r/a=dkl

Bugzilla/WebService/Bug.pm

index 670d234ceeb6d9536207866579fcfae81e9ca6ef..7dedc5badd3856da1fc88d954eb6ae42df7f599f 100644 (file)
@@ -707,19 +707,10 @@ sub add_comment {
     # Append comment
     $bug->add_comment($comment, { isprivate => $params->{is_private},
                                   work_time => $params->{work_time} });
-    
-    # Capture the call to bug->update (which creates the new comment) in 
-    # a transaction so we're sure to get the correct comment_id.
-    
-    my $dbh = Bugzilla->dbh;
-    $dbh->bz_start_transaction();
-    
     $bug->update();
-    
-    my $new_comment_id = $dbh->bz_last_key('longdescs', 'comment_id');
-    
-    $dbh->bz_commit_transaction();
-    
+
+    my $new_comment_id = $bug->{added_comments}[0]->id;
+
     # Send mail.
     Bugzilla::BugMail::Send($bug->bug_id, { changer => $user });