]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
rs6000: Fix ICE for invalid constants in built-in functions
authorPeter Bergner <bergner@linux.ibm.com>
Thu, 16 Jan 2025 16:53:27 +0000 (10:53 -0600)
committerPeter Bergner <bergner@linux.ibm.com>
Fri, 24 Jan 2025 15:23:19 +0000 (09:23 -0600)
For invalid constant operand values used in built-in functions, return
const0_rtx to signify an error occurred during expansion.

2025-01-16  Peter Bergner  <bergner@linux.ibm.com>

gcc/
* config/rs6000/rs6000-builtin.cc (rs6000_expand_builtin): Return
const0_rtx when there is an error.

gcc/testsuite/
* gcc.target/powerpc/mma-builtin-error.c: New test.

(cherry picked from commit 0696af74b3392e2178215607337b116d1bb53e34)

gcc/config/rs6000/rs6000-builtin.cc
gcc/testsuite/gcc.target/powerpc/mma-builtin-error.c [new file with mode: 0644]

index d467db29e8e38780c7f363915c6c44d7aa691001..a1549fe2a15f879b908948ba47cfe804e09bd681 100644 (file)
@@ -3602,7 +3602,7 @@ rs6000_expand_builtin (tree exp, rtx target, rtx /* subtarget */,
                error ("argument %d must be a literal between 0 and %d,"
                       " inclusive",
                       bifaddr->restr_opnd[i], p);
-               return CONST0_RTX (mode[0]);
+               return const0_rtx;
              }
            break;
          }
@@ -3619,7 +3619,7 @@ rs6000_expand_builtin (tree exp, rtx target, rtx /* subtarget */,
                       " inclusive",
                       bifaddr->restr_opnd[i], bifaddr->restr_val1[i],
                       bifaddr->restr_val2[i]);
-               return CONST0_RTX (mode[0]);
+               return const0_rtx;
              }
            break;
          }
@@ -3636,7 +3636,7 @@ rs6000_expand_builtin (tree exp, rtx target, rtx /* subtarget */,
                       "between %d and %d, inclusive",
                       bifaddr->restr_opnd[i], bifaddr->restr_val1[i],
                       bifaddr->restr_val2[i]);
-               return CONST0_RTX (mode[0]);
+               return const0_rtx;
              }
            break;
          }
@@ -3652,7 +3652,7 @@ rs6000_expand_builtin (tree exp, rtx target, rtx /* subtarget */,
                       "literal %d",
                       bifaddr->restr_opnd[i], bifaddr->restr_val1[i],
                       bifaddr->restr_val2[i]);
-               return CONST0_RTX (mode[0]);
+               return const0_rtx;
              }
            break;
          }
diff --git a/gcc/testsuite/gcc.target/powerpc/mma-builtin-error.c b/gcc/testsuite/gcc.target/powerpc/mma-builtin-error.c
new file mode 100644 (file)
index 0000000..a87a157
--- /dev/null
@@ -0,0 +1,11 @@
+/* { dg-do compile } */
+/* { dg-require-effective-target power10_ok } */
+/* { dg-options "-O2 -mdejagnu-cpu=power10" } */
+
+typedef unsigned char vec_t __attribute__((vector_size(16)));
+
+void
+foo (__vector_quad *dst, vec_t vec0, vec_t vec1) /* { dg-error "argument 5 must be a literal between 0 and 15, inclusive" } */
+{
+  __builtin_mma_pmxvi8ger4 (dst, vec0, vec1, 15, 15, -1);
+}