]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
ssh: fix out of bounds read in banner parsing
authorVictor Julien <victor@inliniac.net>
Thu, 19 Apr 2018 09:27:43 +0000 (11:27 +0200)
committerVictor Julien <victor@inliniac.net>
Mon, 16 Jul 2018 11:30:50 +0000 (13:30 +0200)
Reported-by: Henning Perl
src/app-layer-ssh.c

index 91aa9c59b657ff2f264820c3a48e48caea9bd85f..23435fffa18ac1bebd2582c0fdf4a4141d85c52b 100644 (file)
@@ -69,7 +69,7 @@ static int SSHParseBanner(SshState *state, SshHeader *header, const uint8_t *inp
     uint32_t line_len = input_len;
 
     /* is it the version line? */
-    if (SCMemcmp("SSH-", line_ptr, 4) != 0) {
+    if (line_len >= 4 && SCMemcmp("SSH-", line_ptr, 4) != 0) {
         SCReturnInt(-1);
     }