]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: cs35l56: Use SOC_ENUM_EXT_ACC() for CAL_SET_STATUS control
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Thu, 20 Nov 2025 13:44:36 +0000 (13:44 +0000)
committerMark Brown <broonie@kernel.org>
Thu, 20 Nov 2025 16:04:21 +0000 (16:04 +0000)
Use the new SOC_ENUM_EXT_ACC() macro instead of SOC_ENUM_EXT() to
define the CAL_SET_STATUS control, so that it is marked as read-only
and volatile.

This avoids userland code expecting to be able to write to it and
then getting an unexpected EPERM error, or assuming that its value
can never change.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://patch.msgid.link/20251120134437.1179191-4-rf@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/cs35l56.c

index 802658720510d5f6b6efe49be337fa3600b01a84..f5fd20c8cce1a6ff45fff320e581b345ccab8089 100644 (file)
@@ -95,8 +95,9 @@ static const struct snd_kcontrol_new cs35l56_controls[] = {
        SOC_SINGLE_EXT("Posture Number", CS35L56_MAIN_POSTURE_NUMBER,
                       0, 255, 0,
                       cs35l56_dspwait_get_volsw, cs35l56_dspwait_put_volsw),
-       SOC_ENUM_EXT("CAL_SET_STATUS", cs35l56_cal_set_status_enum,
-                    cs35l56_cal_set_status_ctl_get, NULL),
+       SOC_ENUM_EXT_ACC("CAL_SET_STATUS", cs35l56_cal_set_status_enum,
+                        cs35l56_cal_set_status_ctl_get, NULL,
+                        SNDRV_CTL_ELEM_ACCESS_READ | SNDRV_CTL_ELEM_ACCESS_VOLATILE),
 };
 
 static const struct snd_kcontrol_new cs35l63_controls[] = {
@@ -116,8 +117,9 @@ static const struct snd_kcontrol_new cs35l63_controls[] = {
        SOC_SINGLE_EXT("Posture Number", CS35L63_MAIN_POSTURE_NUMBER,
                       0, 255, 0,
                       cs35l56_dspwait_get_volsw, cs35l56_dspwait_put_volsw),
-       SOC_ENUM_EXT("CAL_SET_STATUS", cs35l56_cal_set_status_enum,
-                    cs35l56_cal_set_status_ctl_get, NULL),
+       SOC_ENUM_EXT_ACC("CAL_SET_STATUS", cs35l56_cal_set_status_enum,
+                        cs35l56_cal_set_status_ctl_get, NULL,
+                        SNDRV_CTL_ELEM_ACCESS_READ | SNDRV_CTL_ELEM_ACCESS_VOLATILE),
 };
 
 static SOC_VALUE_ENUM_SINGLE_DECL(cs35l56_asp1tx1_enum,