after some thought, perhaps a better fix

diff --git a/src/lib/util/dict_util.c b/src/lib/util/dict_util.c
index 0205af1b1793db01f93420e412ea967cfc3c8f82..ea155d5fff93b3b01068393ffb077a33bd78bddb 100644 (file)
--- a/src/lib/util/dict_util.c
+++ b/src/lib/util/dict_util.c
@@ -2213,6 +2213,8 @@ ssize_t dict_attr_search(fr_dict_attr_err_t *err, fr_dict_attr_t const **out,
        ssize_t                 slen = 0;
        fr_sbuff_t              our_in = FR_SBUFF_NO_ADVANCE(in);
 
+       if (internal && !dict_gctx->internal) internal = false;
+
        /*
         *      Always going to fail...
         */
@@ -2221,10 +2223,6 @@ ssize_t dict_attr_search(fr_dict_attr_err_t *err, fr_dict_attr_t const **out,
                return 0;
        }
 
-#ifdef __clang_analyzer__
-       if (internal && !dict_gctx->internal) return -1;
-#endif
-
        /*
         *      dict_def search in the specified dictionary
         */