voicemail: get real last_message_index and count_messages, ODBC resequence

change last_message_index to read the max msgnum stored in the database
change count_messages to actually count the number of messages.

last_message_index change:
  This fixed overwriting of the last message if msgnum=0 was missing.
  Previously every incoming message would overwrite msgnum=1.
count_messages change:
  allows us to detect when requencing is required in opneA_mailbox.
resequence enabled for ODBC storage:
  Assists with fixing up corrupt databases with gaps, but only when
  a user actively opens there mailboxes.

(closes issue #18692,#18582,#19032)
Reported by: elguero
Patches:
      based on odbc_resequence_mailbox2.1.diff uploaded by elguero (license 37)
Tested by: elguero, nivek, alecdavis

Review: https://reviewboard.asterisk.org/r/1153/

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@312174 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/apps/app_voicemail.c b/apps/app_voicemail.c
index e34ced8024c53dfade6a0c8e8c0b3db1b116405d..6b482e210153e5b7981cdd34272aeb441f6431dd 100644 (file)
--- a/apps/app_voicemail.c
+++ b/apps/app_voicemail.c
@@ -2539,7 +2539,7 @@ static int retrieve_file(char *dir, int msgnum)
                ast_odbc_release_obj(obj);
        } else
                ast_log(LOG_WARNING, "Failed to obtain database object for '%s'!\n", odbc_database);
-yuck:  
+yuck:
        if (f)
                fclose(f);
        if (fd > -1)
@@ -2560,7 +2560,8 @@ static int last_message_index(struct ast_vm_user *vmu, char *dir)
        struct odbc_obj *obj;
        obj = ast_odbc_request_obj(odbc_database, 0);
        if (obj) {
-               snprintf(sql, sizeof(sql), "SELECT COUNT(*) FROM %s WHERE dir=?",odbc_table);
+               snprintf(sql, sizeof(sql), "SELECT msgnum FROM %s WHERE dir=? order by msgnum desc limit 1", odbc_table);
+
                stmt = ast_odbc_prepare_and_execute(obj, generic_prepare, &gps);
                if (!stmt) {
                        ast_log(LOG_WARNING, "SQL Execute error!\n[%s]\n\n", sql);
@@ -2569,7 +2570,12 @@ static int last_message_index(struct ast_vm_user *vmu, char *dir)
                }
                res = SQLFetch(stmt);
                if ((res != SQL_SUCCESS) && (res != SQL_SUCCESS_WITH_INFO)) {
-                       ast_log(LOG_WARNING, "SQL Fetch error!\n[%s]\n\n", sql);
+                       if (res == SQL_NO_DATA) {
+                               ast_log(AST_LOG_DEBUG, "Directory '%s' has no messages and therefore no index was retrieved.\n", dir);
+                       } else {
+                               ast_log(AST_LOG_WARNING, "SQL Fetch error!\n[%s]\n\n", sql);
+                       }
+
                        SQLFreeHandle (SQL_HANDLE_STMT, stmt);
                        ast_odbc_release_obj(obj);
                        goto yuck;
@@ -2582,12 +2588,13 @@ static int last_message_index(struct ast_vm_user *vmu, char *dir)
                        goto yuck;
                }
                if (sscanf(rowdata, "%30d", &x) != 1)
-                       ast_log(LOG_WARNING, "Failed to read message count!\n");
+                       ast_log(LOG_WARNING, "Failed to read message index!\n");
                SQLFreeHandle (SQL_HANDLE_STMT, stmt);
                ast_odbc_release_obj(obj);
+               return x;
        } else
                ast_log(LOG_WARNING, "Failed to obtain database object for '%s'!\n", odbc_database);
-yuck:  
+yuck:
        return x - 1;
 }
 
@@ -2633,13 +2640,54 @@ static int message_exists(char *dir, int msgnum)
                ast_odbc_release_obj(obj);
        } else
                ast_log(LOG_WARNING, "Failed to obtain database object for '%s'!\n", odbc_database);
-yuck:  
+yuck:
        return x;
 }
 
 static int count_messages(struct ast_vm_user *vmu, char *dir)
 {
-       return last_message_index(vmu, dir) + 1;
+       int x = 0;
+       int res;
+       SQLHSTMT stmt;
+       char sql[PATH_MAX];
+       char rowdata[20];
+       char *argv[] = { dir };
+       struct generic_prepare_struct gps = { .sql = sql, .argc = 1, .argv = argv };
+
+       struct odbc_obj *obj;
+       obj = ast_odbc_request_obj(odbc_database, 0);
+       if (obj) {
+               snprintf(sql, sizeof(sql), "SELECT COUNT(*) FROM %s WHERE dir=?", odbc_table);
+               stmt = ast_odbc_prepare_and_execute(obj, generic_prepare, &gps);
+               if (!stmt) {
+                       ast_log(AST_LOG_WARNING, "SQL Execute error!\n[%s]\n\n", sql);
+                       ast_odbc_release_obj(obj);
+                       goto yuck;
+               }
+               res = SQLFetch(stmt);
+               if ((res != SQL_SUCCESS) && (res != SQL_SUCCESS_WITH_INFO)) {
+                       ast_log(AST_LOG_WARNING, "SQL Fetch error!\n[%s]\n\n", sql);
+                       SQLFreeHandle (SQL_HANDLE_STMT, stmt);
+                       ast_odbc_release_obj(obj);
+                       goto yuck;
+               }
+               res = SQLGetData(stmt, 1, SQL_CHAR, rowdata, sizeof(rowdata), NULL);
+               if ((res != SQL_SUCCESS) && (res != SQL_SUCCESS_WITH_INFO)) {
+                       ast_log(AST_LOG_WARNING, "SQL Get Data error!\n[%s]\n\n", sql);
+                       SQLFreeHandle (SQL_HANDLE_STMT, stmt);
+                       ast_odbc_release_obj(obj);
+                       goto yuck;
+               }
+               if (sscanf(rowdata, "%30d", &x) != 1)
+                       ast_log(AST_LOG_WARNING, "Failed to read message count!\n");
+               SQLFreeHandle (SQL_HANDLE_STMT, stmt);
+               ast_odbc_release_obj(obj);
+               return x;
+       } else
+               ast_log(AST_LOG_WARNING, "Failed to obtain database object for '%s'!\n", odbc_database);
+yuck:
+       return x - 1;
+
 }
 
 static void delete_file(char *sdir, int smsg)
@@ -2834,7 +2882,7 @@ static int store_file(char *dir, char *mailboxuser, char *mailboxcontext, int ms
                ast_odbc_release_obj(obj);
        } else
                ast_log(LOG_WARNING, "Failed to obtain database object for '%s'!\n", odbc_database);
-yuck:  
+yuck:
        if (cfg)
                ast_config_destroy(cfg);
        if (fdm != MAP_FAILED)
@@ -3911,7 +3959,7 @@ static int inboxcount(const char *mailbox, int *newmsgs, int *oldmsgs)
        } else
                ast_log(LOG_WARNING, "Failed to obtain database object for '%s'!\n", odbc_database);
                
-yuck:  
+yuck:
        return x;
 }
 
@@ -4557,7 +4605,7 @@ leave_vm_out:
        return res;
 }
 
-#if !defined(IMAP_STORAGE) && !defined(ODBC_STORAGE)
+#if !defined(IMAP_STORAGE)
 static int resequence_mailbox(struct ast_vm_user *vmu, char *dir, int stopcount)
 {
        /* we know the actual number of messages, so stop process when number is hit */
@@ -6035,14 +6083,10 @@ static int open_mailbox(struct vm_state *vms, struct ast_vm_user *vmu,int box)
 
        if (last_msg < -1) {
                return last_msg;
-       }
-#ifndef ODBC_STORAGE
-       else if (vms->lastmsg != last_msg)
-       {
+       } else if (vms->lastmsg != last_msg) {
                ast_log(LOG_NOTICE, "Resequencing Mailbox: %s, expected %d but found %d message(s) in box with max threshold of %d.\n", vms->curdir, last_msg + 1, vms->lastmsg + 1, vmu->maxmsg);
                res = resequence_mailbox(vmu, vms->curdir, count_msg);
        }
-#endif
 
        return 0;
 }