]> git.ipfire.org Git - thirdparty/iproute2.git/commitdiff
tc: ct: Fix invalid pointer dereference
authorRoi Dayan <roid@nvidia.com>
Wed, 7 Dec 2022 08:22:13 +0000 (10:22 +0200)
committerStephen Hemminger <stephen@networkplumber.org>
Wed, 7 Dec 2022 16:56:30 +0000 (08:56 -0800)
Using macro NEXT_ARG_FWD does not validate argc.
Use macro NEXT_ARG which validates argc while parsing args
in the same loop iteration.

Fixes: c8a494314c40 ("tc: Introduce tc ct action")
Signed-off-by: Roi Dayan <roid@nvidia.com>
Reviewed-by: Paul Blakey <paulb@nvidia.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
tc/m_ct.c

index a02bf0cc16556429f8c568ccd94578819eda3921..54d64867abcb758e6e6ad490961ffb224cfe6e21 100644 (file)
--- a/tc/m_ct.c
+++ b/tc/m_ct.c
@@ -243,7 +243,7 @@ parse_ct(struct action_util *a, int *argc_p, char ***argv_p, int tca_id,
                                return -1;
                        }
 
-                       NEXT_ARG_FWD();
+                       NEXT_ARG();
                        if (matches(*argv, "port") != 0)
                                continue;