]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
PCI: aardvark: Silence 'set affinity failed' warning
authorMarek Vasut <marek.vasut+renesas@mailbox.org>
Tue, 23 Jul 2024 13:27:02 +0000 (15:27 +0200)
committerBjorn Helgaas <bhelgaas@google.com>
Mon, 29 Jul 2024 17:46:35 +0000 (12:46 -0500)
Use MSI_FLAG_NO_AFFINITY, which keeps .irq_set_affinity() unset and allows
migrate_one_irq() to exit right away, without warnings like this:

  IRQ...: set affinity failed(-22)

Remove the .irq_set_affinity() implementation that is no longer needed.

Link: https://lore.kernel.org/r/20240723132958.41320-3-marek.vasut+renesas@mailbox.org
Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
[bhelgaas: commit log]
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
drivers/pci/controller/pci-aardvark.c

index 8b3e1a079cf3b8d854564691024c6a9959b6f9a6..ea9b72e0269d46ddcbe4cf61395994ac49e72c12 100644 (file)
@@ -1304,12 +1304,6 @@ static void advk_msi_irq_compose_msi_msg(struct irq_data *data,
        msg->data = data->hwirq;
 }
 
-static int advk_msi_set_affinity(struct irq_data *irq_data,
-                                const struct cpumask *mask, bool force)
-{
-       return -EINVAL;
-}
-
 static void advk_msi_irq_mask(struct irq_data *d)
 {
        struct advk_pcie *pcie = d->domain->host_data;
@@ -1353,7 +1347,6 @@ static void advk_msi_top_irq_unmask(struct irq_data *d)
 static struct irq_chip advk_msi_bottom_irq_chip = {
        .name                   = "MSI",
        .irq_compose_msi_msg    = advk_msi_irq_compose_msi_msg,
-       .irq_set_affinity       = advk_msi_set_affinity,
        .irq_mask               = advk_msi_irq_mask,
        .irq_unmask             = advk_msi_irq_unmask,
 };
@@ -1451,7 +1444,8 @@ static struct irq_chip advk_msi_irq_chip = {
 
 static struct msi_domain_info advk_msi_domain_info = {
        .flags  = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
-                 MSI_FLAG_MULTI_PCI_MSI | MSI_FLAG_PCI_MSIX,
+                 MSI_FLAG_NO_AFFINITY | MSI_FLAG_MULTI_PCI_MSI |
+                 MSI_FLAG_PCI_MSIX,
        .chip   = &advk_msi_irq_chip,
 };