]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
turned off default case-folding rules as they wreak havoc with the current unittests,
authorMike Bayer <mike_mp@zzzcomputing.com>
Sat, 12 Aug 2006 17:53:04 +0000 (17:53 +0000)
committerMike Bayer <mike_mp@zzzcomputing.com>
Sat, 12 Aug 2006 17:53:04 +0000 (17:53 +0000)
temporary isintance() checks in ASNIIdentifierPreparer which will be replaced with visit_
methodology

lib/sqlalchemy/ansisql.py
test/engine/reflection.py

index e1791324df5b41a4d3cf6988c05bef13125633db..84b925b498015ffbe3f41b13308eedce377658d2 100644 (file)
@@ -750,12 +750,12 @@ class ANSIIdentifierPreparer(object):
     
     def _prepare_table(self, table, use_schema=False):
         names = []
-        if table.quote:
+        if isinstance(table, schema.Table) and table.quote:
             names.append(self._quote_identifier(table.name))
         else:
-            names.append(self._fold_identifier_case(table.name))
+            names.append(table.name) #self._fold_identifier_case(table.name))
         
-        if not self.omit_schema and use_schema and table.schema:
+        if not self.omit_schema and use_schema and isinstance(table, schema.Table) and table.schema:
             if table.quote_schema:
                 names.insert(0, self._quote_identifier(table.schema))
             else:
@@ -765,10 +765,10 @@ class ANSIIdentifierPreparer(object):
 
     def _prepare_column(self, column, use_table=True, **kwargs):
         names = []
-        if column.quote:
+        if isinstance(column, schema.Column) and column.quote:
             names.append(self._quote_identifier(column.name))
         else:
-            names.append(self._fold_identifier_case(column.name))
+            names.append(column.name) #self._fold_identifier_case(column.name))
 
         if use_table:
             names.insert(0, self._prepare_table(column.table, **kwargs))
index de2651bd2d5e6188f68b673dc70cec82668ab7a6..52fc2987d676c2eea6dd69bc9dcf6e3ff0fd7bf1 100644 (file)
@@ -290,6 +290,7 @@ class CreateDropTest(PersistTest):
 
 class SchemaTest(PersistTest):
     # this test should really be in the sql tests somewhere, not engine
+    @testbase.unsupported('sqlite')
     def testiteration(self):
         metadata = MetaData()
         table1 = Table('table1', metadata,