]> git.ipfire.org Git - thirdparty/mtr.git/commitdiff
warnings: do not take abs() when data type is unsigned
authorSami Kerola <kerolasa@iki.fi>
Mon, 15 Aug 2016 20:23:28 +0000 (21:23 +0100)
committerSami Kerola <kerolasa@iki.fi>
Mon, 15 Aug 2016 20:56:14 +0000 (21:56 +0100)
Taking the absolute value of unsigned type 'unsigned int' has no effect.

net.c

diff --git a/net.c b/net.c
index fa5b3ef8e1014357aebfcf3bb4a5f1fa6482b0bc..47b0c9bac52cd0385f86410ded8262c12fb3beeb 100644 (file)
--- a/net.c
+++ b/net.c
@@ -256,7 +256,7 @@ int udp_checksum(void *pheader, void *udata, int psize, int dsize, int alt_check
 {
   unsigned int tsize = psize + dsize;
   char csumpacket[tsize];
-  memset(csumpacket, (unsigned char) abs(bitpattern), abs(tsize));
+  memset(csumpacket, (unsigned char) abs(bitpattern), tsize);
   if (alt_checksum && dsize >= 2) {
     csumpacket[psize + sizeof(struct UDPHeader)] = 0;
     csumpacket[psize + sizeof(struct UDPHeader) + 1] = 0;