]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: Allow no address to be defined for virtio-scsi iothread attach
authorJohn Ferlan <jferlan@redhat.com>
Thu, 7 Jun 2018 00:21:26 +0000 (20:21 -0400)
committerJohn Ferlan <jferlan@redhat.com>
Mon, 11 Jun 2018 22:46:07 +0000 (18:46 -0400)
https://bugzilla.redhat.com/show_bug.cgi?id=1583623

When attaching a virtio-scsi with IOThreads for the config of a
live domain, allow the <address> to not be defined thus allowing
post parse processing to fill in the address. This allows parsing
of an individual device to succeed for attach config.

Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_domain.c

index cd8870ae1fe9cb8f1c22d1e913862b89079c4cc0..ac37fe121231c21e92231623a76a866cf8d3c2fa 100644 (file)
@@ -4781,7 +4781,8 @@ qemuDomainCheckSCSIControllerIOThreads(const virDomainControllerDef *controller,
     if (!controller->iothread)
         return true;
 
-    if (controller->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI &&
+    if (controller->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE &&
+        controller->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI &&
         controller->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW) {
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                        _("virtio-scsi IOThreads only available for virtio "