Fix #12845 - Modal#hide should only be called with an event argument

Closes #12850

diff --git a/dist/js/bootstrap.js b/dist/js/bootstrap.js
index 1bf7ffafa9550bfcb35842fbb8ae009a26525e6f..b9ae0fc11fca589edac852c2699d1a9083df6c3c 100644 (file)
--- a/dist/js/bootstrap.js
+++ b/dist/js/bootstrap.js
@@ -817,7 +817,7 @@ if (typeof jQuery === 'undefined') { throw new Error('Bootstrap\'s JavaScript re
   }
 
   Modal.prototype.toggle = function (_relatedTarget) {
-    return this[!this.isShown ? 'show' : 'hide'](_relatedTarget)
+    return this.isShown ? this.hide() : this.show(_relatedTarget)
   }
 
   Modal.prototype.show = function (_relatedTarget) {

diff --git a/js/modal.js b/js/modal.js
index 454d7d57a35bc7371372b6d065eb4936a4c47178..ec358696ff9b048c389c29112164679350bb081c 100644 (file)
--- a/js/modal.js
+++ b/js/modal.js
@@ -36,7 +36,7 @@
   }
 
   Modal.prototype.toggle = function (_relatedTarget) {
-    return this[!this.isShown ? 'show' : 'hide'](_relatedTarget)
+    return this.isShown ? this.hide() : this.show(_relatedTarget)
   }
 
   Modal.prototype.show = function (_relatedTarget) {