]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
PCI: plda: Protect root bus removal with rescan lock
authorHans Zhang <18255117159@163.com>
Thu, 21 May 2026 16:18:22 +0000 (00:18 +0800)
committerBjorn Helgaas <bhelgaas@google.com>
Thu, 18 Jun 2026 16:50:55 +0000 (11:50 -0500)
Hold the pci_rescan_remove_lock lock while stopping and removing a root bus
to avoid racing with concurrent rescan or hotplug operations triggered via
sysfs.  Such races may lead to use-after-free issues or system crashes.

Signed-off-by: Hans Zhang <18255117159@163.com>
Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
[bhelgaas: commit log]
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Link: https://patch.msgid.link/20260521161822.132996-10-18255117159@163.com
drivers/pci/controller/plda/pcie-plda-host.c

index 3c2f683830107b9c40ac633a51923a0956ba7a19..f9a34f323ad8c51d14e1e06df8b1214dcbb057b5 100644 (file)
@@ -640,8 +640,10 @@ EXPORT_SYMBOL_GPL(plda_pcie_host_init);
 
 void plda_pcie_host_deinit(struct plda_pcie_rp *port)
 {
+       pci_lock_rescan_remove();
        pci_stop_root_bus(port->bridge->bus);
        pci_remove_root_bus(port->bridge->bus);
+       pci_unlock_rescan_remove();
 
        plda_pcie_irq_domain_deinit(port);