more descriptive errors for people who don't read the documentation

diff --git a/src/main/map.c b/src/main/map.c
index 451a58a15c473c3d1db69042a3d8ac6a4bb466b6..4396ed63edf3c4fc47fcc0d8a1b6e5921d3a6a8b 100644 (file)
--- a/src/main/map.c
+++ b/src/main/map.c
@@ -1091,6 +1091,12 @@ int map_to_request(REQUEST *request, vp_map_t const *map, radius_map_getvalue_t
         */
        if (((map->lhs->tmpl_list == PAIR_LIST_COA) ||
             (map->lhs->tmpl_list == PAIR_LIST_DM)) && !request->coa) {
+               if ((request->packet->code == PW_CODE_COA_REQUEST) ||
+                   (request->packet->code == PW_CODE_DISCONNECT_REQUEST)) {
+                       REDEBUG("You cannot do 'update coa' when processing a CoA / Disconnect request.  Use 'update request' instead.");
+                       return -2;
+               }
+
                if (!request_alloc_coa(context)) {
                        REDEBUG("Failed to create a CoA/Disconnect Request message");
                        return -2;