]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virSecuritySELinuxContextListAppend: Remove unreachable cleanup
authorPeter Krempa <pkrempa@redhat.com>
Wed, 4 Aug 2021 09:13:10 +0000 (11:13 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Fri, 6 Aug 2021 06:53:26 +0000 (08:53 +0200)
'item' is always NULLed-out by VIR_APPEND_ELEMENT and 'ret' variable is
always 0 when used so both can be removed.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/security/security_selinux.c

index 30fb6028aa04eb95c8e4e0d3a2bb2417b674de7d..9ff35a7be557643657e04135ac9f68ac853bdc7e 100644 (file)
@@ -114,7 +114,6 @@ virSecuritySELinuxContextListAppend(virSecuritySELinuxContextList *list,
                                     bool remember,
                                     bool restore)
 {
-    int ret = -1;
     virSecuritySELinuxContextItem *item = NULL;
 
     item = g_new0(virSecuritySELinuxContextItem, 1);
@@ -127,9 +126,7 @@ virSecuritySELinuxContextListAppend(virSecuritySELinuxContextList *list,
 
     VIR_APPEND_ELEMENT(list->items, list->nItems, item);
 
-    ret = 0;
-    virSecuritySELinuxContextItemFree(item);
-    return ret;
+    return 0;
 }
 
 static void