]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
Pull check for non-NULL randle after check for NULL randle
authorJames Jones <jejones3141@gmail.com>
Tue, 30 May 2023 20:06:07 +0000 (15:06 -0500)
committerArran Cudbard-Bell <a.cudbardb@freeradius.org>
Wed, 31 May 2023 01:41:45 +0000 (20:41 -0500)
randle is local to mod_authenticate(), so in the then clause
of an if checking for randle being NULL, randle won't be non-NULL.

src/modules/rlm_imap/rlm_imap.c

index 93b4c4a4201874970560df5df448b392c693d522..23c28918d6cbd29291bde093dd0a7121c72eddfc 100644 (file)
@@ -177,7 +177,6 @@ static unlang_action_t CC_HINT(nonnull(1,2)) mod_authenticate(rlm_rcode_t *p_res
 
        randle = imap_slab_reserve(t->slab);
        if (!randle){
-               if (randle) imap_slab_release(randle);
                RETURN_MODULE_FAIL;
        }