Bug 679516: Call Bugzilla::Object->remove_from_db when deleting an object

r/a=LpSolit

diff --git a/Bugzilla/Field.pm b/Bugzilla/Field.pm
index aa35511824c01dc606083d710eed8fb380cf6db1..6b42cc4afb592e0e19a21f3d74aa4145319009dd 100644 (file)
--- a/Bugzilla/Field.pm
+++ b/Bugzilla/Field.pm
@@ -948,7 +948,7 @@ sub remove_from_db {
     }
 
     # Once we reach here, we should be OK to delete.
-    $dbh->do('DELETE FROM fielddefs WHERE id = ?', undef, $self->id);
+    $self->SUPER::remove_from_db();
 
     my $type = $self->type;
 

diff --git a/Bugzilla/Milestone.pm b/Bugzilla/Milestone.pm
index 92bc2192a719af87768099a5218ecc6ae3d2a0ae..61e2a12bb6743f01df1e04c0f60aa1d1387b0632 100644 (file)
--- a/Bugzilla/Milestone.pm
+++ b/Bugzilla/Milestone.pm
@@ -158,7 +158,7 @@ sub remove_from_db {
         }
     }
 
-    $dbh->do('DELETE FROM milestones WHERE id = ?', undef, $self->id);
+    $self->SUPER::remove_from_db();
 }
 
 ################################

diff --git a/Bugzilla/Product.pm b/Bugzilla/Product.pm
index 85524ac4739ca184776066e8719a1874624c6847..64a146be9dab7c1ef983c325aa204b8e5ed99230 100644 (file)
--- a/Bugzilla/Product.pm
+++ b/Bugzilla/Product.pm
@@ -317,7 +317,7 @@ sub remove_from_db {
         }
     }
 
-    $dbh->do("DELETE FROM products WHERE id = ?", undef, $self->id);
+    $self->SUPER::remove_from_db();
 
     $dbh->bz_commit_transaction();
 

diff --git a/Bugzilla/Status.pm b/Bugzilla/Status.pm
index ffef600de36ad1631a8e22bd36a13de218bf7919..f3d6d808cee67ed3715df9abbcd40a641caf6398 100644 (file)
--- a/Bugzilla/Status.pm
+++ b/Bugzilla/Status.pm
@@ -76,14 +76,7 @@ sub create {
 
 sub remove_from_db {
     my $self = shift;
-    my $dbh = Bugzilla->dbh;
-    my $id = $self->id;
-    $dbh->bz_start_transaction();
     $self->SUPER::remove_from_db();
-    $dbh->do('DELETE FROM status_workflow
-               WHERE old_status = ? OR new_status = ?',
-              undef, $id, $id);
-    $dbh->bz_commit_transaction();
     delete Bugzilla->request_cache->{status_bug_state_open};
 }