]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
backup: Add new domain:checkpoint access control
authorEric Blake <eblake@redhat.com>
Wed, 13 Jun 2018 12:04:57 +0000 (07:04 -0500)
committerEric Blake <eblake@redhat.com>
Fri, 26 Jul 2019 21:48:58 +0000 (16:48 -0500)
Creating a checkpoint does not modify guest-visible state,
but does modify host resources.  Rather than reuse existing
domain:write, domain:block_write, or domain:snapshot access
controls, it seems better to introduce a new access control
specific to tasks related to checkpoints and incremental
backups of guest disk state.

Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
src/access/viraccessperm.c
src/access/viraccessperm.h

index 74993e9f29ecdbd4312fb3f39f52d828767530e0..33db7752b6a124f65eb8ca9307971e42e875f337 100644 (file)
@@ -39,7 +39,8 @@ VIR_ENUM_IMPL(virAccessPermDomain,
               "getattr", "read", "write", "read_secure",
               "start", "stop", "reset",
               "save", "delete",
-              "migrate", "snapshot", "suspend", "hibernate", "core_dump", "pm_control",
+              "migrate", "checkpoint", "snapshot", "suspend", "hibernate",
+              "core_dump", "pm_control",
               "init_control", "inject_nmi", "send_input", "send_signal",
               "fs_trim", "fs_freeze",
               "block_read", "block_write", "mem_read",
index d4b9c69c1e1c1fe7d38a906da41bbc413b113850..a42512d5e0e2d331777f2550a872e3576fe6817a 100644 (file)
@@ -186,6 +186,12 @@ typedef enum {
      */
     VIR_ACCESS_PERM_DOMAIN_MIGRATE,   /* Host migration */
 
+    /**
+     * @desc: Checkpoint domain
+     * @message: Checkpointing domain requires authorization
+     */
+    VIR_ACCESS_PERM_DOMAIN_CHECKPOINT,  /* Checkpoint disks */
+
     /**
      * @desc: Snapshot domain
      * @message: Snapshotting domain requires authorization