]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/panic: avoid WARN when checking format support
authorFrancesco Valla <francesco@valla.it>
Wed, 17 Dec 2025 08:06:56 +0000 (09:06 +0100)
committerJocelyn Falempe <jfalempe@redhat.com>
Fri, 19 Dec 2025 22:06:41 +0000 (23:06 +0100)
Use drm_draw_can_convert_from_xrgb8888() instead of
drm_draw_color_from_xrgb8888() while checking if a color format is
usable. This avoids a WARN in case the first format is not usable.

Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
Signed-off-by: Francesco Valla <francesco@valla.it>
Link: https://patch.msgid.link/20251217-drm_draw_conv_check-v3-3-15b6f8bc1cbc@valla.it
Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com>
drivers/gpu/drm/drm_panic.c

index f42be7f1d8c2ed459616c0e37ee9f2481cd45927..2050094e051877802014a1b399dea78a5a7c3f48 100644 (file)
@@ -872,7 +872,7 @@ static bool drm_panic_is_format_supported(const struct drm_format_info *format)
 {
        if (format->num_planes != 1)
                return false;
-       return drm_draw_color_from_xrgb8888(0xffffff, format->format) != 0;
+       return drm_draw_can_convert_from_xrgb8888(format->format);
 }
 
 static void draw_panic_dispatch(struct drm_scanout_buffer *sb)