]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib: istream-sized - remove explicit i_error() logging
authorTimo Sirainen <timo.sirainen@dovecot.fi>
Fri, 23 Dec 2016 17:26:17 +0000 (12:26 -0500)
committerGitLab <gitlab@git.dovecot.net>
Fri, 23 Dec 2016 19:08:57 +0000 (21:08 +0200)
The stream_errno is set, so it's the caller's responsibility to log the
error. There's no need to log it twice.

src/lib/istream-sized.c

index 0853cc429aa6dded2358b2e48b64a35b56e073da..6f54c5317b54f8fc01b83de6a5538afaebb35045 100644 (file)
@@ -89,9 +89,6 @@ static ssize_t i_stream_sized_read(struct istream_private *stream)
        else if (pos > left) {
                error = sstream->error_callback(&data, sstream->error_context);
                io_stream_set_error(&stream->iostream, "%s", error);
-               i_error("read(%s) failed: %s",
-                       i_stream_get_name(&stream->istream),
-                       stream->iostream.error);
                pos = left;
                stream->istream.eof = TRUE;
                stream->istream.stream_errno = EINVAL;
@@ -103,9 +100,6 @@ static ssize_t i_stream_sized_read(struct istream_private *stream)
        } else {
                error = sstream->error_callback(&data, sstream->error_context);
                io_stream_set_error(&stream->iostream, "%s", error);
-               i_error("read(%s) failed: %s",
-                       i_stream_get_name(&stream->istream),
-                       stream->iostream.error);
                stream->istream.stream_errno = EINVAL;
        }