]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
pwm: img: Fix PM reference leak in img_pwm_enable()
authorZou Wei <zou_wei@huawei.com>
Wed, 12 May 2021 03:57:17 +0000 (11:57 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 20 Jul 2021 14:02:16 +0000 (16:02 +0200)
[ Upstream commit fde25294dfd8e36e4e30b693c27a86232864002a ]

pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pwm/pwm-img.c

index 6faf5b5a558421233c1808c0242c6c4b047a5331..37200850cdc6dd3732e64dc6ab60049319cd441d 100644 (file)
@@ -156,7 +156,7 @@ static int img_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
        struct img_pwm_chip *pwm_chip = to_img_pwm_chip(chip);
        int ret;
 
-       ret = pm_runtime_get_sync(chip->dev);
+       ret = pm_runtime_resume_and_get(chip->dev);
        if (ret < 0)
                return ret;