]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
spi: imx: Don't expect DMA for i.MX{25,35,50,51,53} cspi devices
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Wed, 8 May 2024 09:56:10 +0000 (11:56 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 27 Jul 2024 08:33:43 +0000 (10:33 +0200)
[ Upstream commit ce1dac560a74220f2e53845ec0723b562288aed4 ]

While in commit 2dd33f9cec90 ("spi: imx: support DMA for imx35") it was
claimed that DMA works on i.MX25, i.MX31 and i.MX35 the respective
device trees don't add DMA channels. The Reference manuals of i.MX31 and
i.MX25 also don't mention the CSPI core being DMA capable. (I didn't
check the others.)

Since commit e267a5b3ec59 ("spi: spi-imx: Use dev_err_probe for failed
DMA channel requests") this results in an error message

spi_imx 43fa4000.spi: error -ENODEV: can't get the TX DMA channel!

during boot. However that isn't fatal and the driver gets loaded just
fine, just without using DMA.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://patch.msgid.link/20240508095610.2146640-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/spi/spi-imx.c

index 0078cb365d8c299646b433ae6ef817a25f586ea8..adcd519c70b19e501ada8425a26a7e9ff3f7c9d1 100644 (file)
@@ -968,7 +968,7 @@ static struct spi_imx_devtype_data imx35_cspi_devtype_data = {
        .rx_available = mx31_rx_available,
        .reset = mx31_reset,
        .fifo_size = 8,
-       .has_dmamode = true,
+       .has_dmamode = false,
        .dynamic_burst = false,
        .has_slavemode = false,
        .devtype = IMX35_CSPI,