]> git.ipfire.org Git - thirdparty/bugzilla.git/commitdiff
Bug 744015: Fix 'use of uninitialized value in string' in PatchReader
authorByron Jones <bjones@mozilla.com>
Tue, 8 May 2012 06:10:16 +0000 (14:10 +0800)
committerByron Jones <bjones@mozilla.com>
Tue, 8 May 2012 06:10:16 +0000 (14:10 +0800)
r=gerv, a=LpSolit

Bugzilla/Attachment/PatchReader.pm

index 3be0555c10d20f6aaa809ecd9bdebf75215326bd..c79b96ed2f79fbd940d86d803f0f33b2a7a18a71 100644 (file)
@@ -200,7 +200,9 @@ sub warn_if_interdiff_might_fail {
 
     # Verify that the revisions in the files are the same.
     foreach my $file (keys %{$old_file_list}) {
-        if ($old_file_list->{$file}{old_revision} ne
+        if (exists $old_file_list->{$file}{old_revision}
+            && exists $new_file_list->{$file}{old_revision}
+            && $old_file_list->{$file}{old_revision} ne
             $new_file_list->{$file}{old_revision})
         {
             return 'interdiff2';