s3: smbd: optimization. Only do the FCHMOD call if needed.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index 7763a09573396c5150dcfa09f5bf59d60c8b6d24..99e0e0462e3c2c1881d75f81e921d179ffccf134 100644 (file)
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -3806,12 +3806,14 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
                 * an overwritten file.
                 */
 
-               int ret = SMB_VFS_FCHMOD(fsp, new_unx_mode);
-               if (ret == -1) {
-                       DBG_INFO("failed to reset "
+               if (new_unx_mode != smb_fname->st.st_ex_mode) {
+                       int ret = SMB_VFS_FCHMOD(fsp, new_unx_mode);
+                       if (ret == -1) {
+                               DBG_INFO("failed to reset "
                                  "attributes of file %s to 0%o\n",
                                  smb_fname_str_dbg(smb_fname),
                                  (unsigned int)new_unx_mode);
+                       }
                }
        }