]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
hoist NULL check to before dereference
authorAlan T. DeKok <aland@freeradius.org>
Tue, 8 Apr 2025 18:03:16 +0000 (14:03 -0400)
committerAlan T. DeKok <aland@freeradius.org>
Tue, 8 Apr 2025 18:03:16 +0000 (14:03 -0400)
src/main/realms.c

index 9d9d990bee4f459a798c3a6988a543f976b0e052..75a38b74077cb960f30a49e7654d098760434d99 100644 (file)
@@ -1640,6 +1640,11 @@ static int server_pool_add(realm_config_t *rc,
                        }
                }
 
+               if (!home) {
+                       ERROR("Failed to find home server %s", value);
+                       goto error;
+               }
+
                if (home->affinity) {
                        if (home->virtual_server) {
                                ERROR("Home server %s is a virtual server, and cannot be used with 'affinity'", home->name);                            
@@ -1669,11 +1674,6 @@ static int server_pool_add(realm_config_t *rc,
                        pool->affinity_group[home->affinity] = home;                    
                }
 
-               if (!home) {
-                       ERROR("Failed to find home server %s", value);
-                       goto error;
-               }
-
                if (do_print) cf_log_info(cs, "\thome_server = %s", home->name);
                pool->servers[num_home_servers++] = home;
        } /* loop over home_server's */