]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: error out on attempt to change blkiotune group name
authorJán Tomko <jtomko@redhat.com>
Thu, 28 Mar 2019 14:01:45 +0000 (15:01 +0100)
committerJán Tomko <jtomko@redhat.com>
Fri, 29 Mar 2019 11:54:41 +0000 (12:54 +0100)
Check that the attribute is the same in qemuDomainDiskChangeSupported
in case somebody tries to change it using the UpdateDevice API.

https://bugzilla.redhat.com/show_bug.cgi?id=1601677

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Laine Stump <laine@laine.org>
src/qemu/qemu_domain.c

index f856a5b081c16a5d70ef05b940f556e9a2d6819a..c6188b38ce3a6d1f9fb79018280e7dc67d71fac6 100644 (file)
@@ -9397,6 +9397,8 @@ qemuDomainDiskChangeSupported(virDomainDiskDefPtr disk,
     CHECK_EQ(blkdeviotune.size_iops_sec,
              "blkdeviotune size_iops_sec",
              true);
+    CHECK_STREQ_NULLABLE(blkdeviotune.group_name,
+                         "blkdeviotune group name");
 
     if (disk->serial && STRNEQ_NULLABLE(disk->serial, orig_disk->serial)) {
         virReportError(VIR_ERR_OPERATION_UNSUPPORTED,