]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
build: avoid $(builddir) in Makefile
authorEric Blake <eblake@redhat.com>
Tue, 21 Aug 2012 20:33:03 +0000 (14:33 -0600)
committerEric Blake <eblake@redhat.com>
Tue, 21 Aug 2012 20:33:03 +0000 (14:33 -0600)
Older automake 1.9.6 (hello there, RHEL 5) did not populate
$(builddir), which meant 'make check' failed with:

make[3]: *** No rule to make target `/.libs/libvirt.la', needed by `check-symfile'.  Stop.

For that matter, even newer automake doesn't directly emit rules
to build .libs/libvirt.la; we are better off basing our rules
on the public ./libvirt.la.

* src/Makefile.am (check-symfile): Delete useless variable.

src/Makefile.am

index 39cbefda53997b6b474bd33804dcbeab68f47666..2f15a370ce4422f489a75a3d586a47914086b429 100644 (file)
@@ -310,8 +310,11 @@ PDWTAGS = \
          echo 'WARNING: install the dwarves package to get pdwtags' >&2; \
        fi
 
-check-symfile: libvirt.syms $(builddir)/.libs/libvirt.la
-       $(AM_V_GEN)$(PERL) $(srcdir)/check-symfile.pl libvirt.syms $(builddir)/.libs/libvirt.so
+# .libs/libvirt.so is built by libtool as a side-effect of the Makefile
+# rule for libvirt.la
+check-symfile: libvirt.syms libvirt.la
+       $(AM_V_GEN)$(PERL) $(srcdir)/check-symfile.pl libvirt.syms \
+         .libs/libvirt.so
 
 PROTOCOL_STRUCTS = \
        $(srcdir)/remote_protocol-structs \