]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/i915/cx0: Add MTL+ .update_active_dpll hook
authorMika Kahola <mika.kahola@intel.com>
Tue, 18 Nov 2025 13:28:30 +0000 (15:28 +0200)
committerMika Kahola <mika.kahola@intel.com>
Wed, 19 Nov 2025 11:32:19 +0000 (13:32 +0200)
Add .update_active_dpll function pointer to support
dpll framework. Reuse ICL function pointer.

v2: Add check for !HAS_LT_PHY (Suraj)
v3: Remove the incorrect !HAS_LT_PHY condition and
    check for existing dpll_mgr

Signed-off-by: Mika Kahola <mika.kahola@intel.com>
Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com> # v1
Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>
Link: https://lore.kernel.org/r/20251118132830.2584422-1-mika.kahola@intel.com
drivers/gpu/drm/i915/display/intel_ddi.c
drivers/gpu/drm/i915/display/intel_dpll_mgr.c

index 002ccd47856d093abe531a4e70d4ddbdf82f7ebc..39d87bc9157184046172a996765defb3027d0ee7 100644 (file)
@@ -3667,8 +3667,8 @@ void intel_ddi_update_active_dpll(struct intel_atomic_state *state,
                intel_atomic_get_new_crtc_state(state, crtc);
        struct intel_crtc *pipe_crtc;
 
-       /* FIXME: Add MTL pll_mgr */
-       if (DISPLAY_VER(display) >= 14 || !intel_encoder_is_tc(encoder))
+       /* FIXME: Add NVL+ and DG2 pll_mgr */
+       if (!intel_encoder_is_tc(encoder) || !display->dpll.mgr)
                return;
 
        for_each_intel_crtc_in_pipe_mask(display->drm, pipe_crtc,
index c45f18201ee897490be4dd34818d43e735a4c0a8..e6dd6f1123d6ffae9c228c2890617584c8f46bb3 100644 (file)
@@ -4449,6 +4449,7 @@ static const struct intel_dpll_mgr mtl_pll_mgr = {
        .compute_dplls = mtl_compute_dplls,
        .get_dplls = mtl_get_dplls,
        .put_dplls = icl_put_dplls,
+       .update_active_dpll = icl_update_active_dpll,
 };
 
 /**