]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: accel: adxl380: fix handling of unavailable "INT1" interrupt
authorFrancesco Lavra <flavra@baylibre.com>
Fri, 28 Nov 2025 17:21:38 +0000 (18:21 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 21 Dec 2025 11:14:10 +0000 (11:14 +0000)
fwnode_irq_get_byname() returns a negative value on failure; if a negative
value is returned, use it as `err` argument for dev_err_probe().
While at it, add a missing trailing newline to the dev_err_probe() error
message.

Fixes: df36de13677a ("iio: accel: add ADXL380 driver")
Signed-off-by: Francesco Lavra <flavra@baylibre.com>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Cc: stable@vger.kernel.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/accel/adxl380.c

index 6d5f1a0d51e97636799f5d5bae8908007dbdad42..aef5109c1ddd9d4a0622d822179fe293c6e77673 100644 (file)
@@ -1784,9 +1784,9 @@ static int adxl380_config_irq(struct iio_dev *indio_dev)
                st->int_map[1] = ADXL380_INT0_MAP1_REG;
        } else {
                st->irq = fwnode_irq_get_byname(dev_fwnode(st->dev), "INT1");
-               if (st->irq > 0)
-                       return dev_err_probe(st->dev, -ENODEV,
-                                            "no interrupt name specified");
+               if (st->irq < 0)
+                       return dev_err_probe(st->dev, st->irq,
+                                            "no interrupt name specified\n");
                st->int_map[0] = ADXL380_INT1_MAP0_REG;
                st->int_map[1] = ADXL380_INT1_MAP1_REG;
        }