vala: Report invalid type in property assignment attempt

Fixes https://gitlab.gnome.org/GNOME/vala/issues/1541

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 605a5bed2ca88fdf947ad957ee5896d26e0b6a8f..5bde146b3a4a706734eaf7830663d24a34c09db9 100644 (file)
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -1088,6 +1088,7 @@ TESTS = \
        semantic/assignment-signal-incompatible-method.test \
        semantic/assignment-signal-incompatible-type.test \
        semantic/assignment-invalid-type.test \
+       semantic/assignment-invalid-type-2.test \
        semantic/cast-gvalue-unsupported.test \
        semantic/cast-gvariant-unsupported.test \
        semantic/cast-void-not-allowed.test \

diff --git a/tests/semantic/assignment-invalid-type-2.test b/tests/semantic/assignment-invalid-type-2.test
new file mode 100644 (file)
index 0000000..ff9d0a8
--- /dev/null
+++ b/tests/semantic/assignment-invalid-type-2.test
@@ -0,0 +1,14 @@
+Invalid Code
+
+enum Foo {
+       MANAM;
+}
+
+class Bar : Object {
+       public Foo foo { get; set; }
+}
+
+void main () {
+       var bar = new Bar ();
+       bar.foo = Foo;
+}

diff --git a/vala/valaassignment.vala b/vala/valaassignment.vala
index 1213e24d09b691890e6028738869a7a9df2255df..ff552deb81877b244ea419f08008ca7d74648233 100644 (file)
--- a/vala/valaassignment.vala
+++ b/vala/valaassignment.vala
@@ -293,6 +293,11 @@ public class Vala.Assignment : Expression {
                if (ma != null) {
                        if (ma.symbol_reference is Property) {
                                unowned Property prop = (Property) ma.symbol_reference;
+                               if (right.value_type == null) {
+                                       error = true;
+                                       Report.error (source_reference, "Assignment: Invalid assignment attempt");
+                                       return false;
+                               }
 
                                unowned DynamicProperty? dynamic_prop = prop as DynamicProperty;
                                if (dynamic_prop != null) {