revert DHCPv6 struct_nested patch

It seems to randomly set the flag to "true" locally and in CI.
even though ASAN doesn't complain

diff --git a/src/protocols/dhcpv6/decode.c b/src/protocols/dhcpv6/decode.c
index 4ad26ab3ee76910c7f464f14d28d405256a31c47..847d27a4cb8bb073b246457ee13c868c02b88529 100644 (file)
--- a/src/protocols/dhcpv6/decode.c
+++ b/src/protocols/dhcpv6/decode.c
@@ -73,7 +73,6 @@ static ssize_t decode_value(TALLOC_CTX *ctx, fr_pair_list_t *out,
        ssize_t                 slen;
        fr_pair_t               *vp = NULL;
        uint8_t                 prefix_len;
-       fr_dhcpv6_decode_ctx_t  *packet_ctx = decode_ctx;
 
        FR_PROTO_HEX_DUMP(data, data_len, "decode_value");
 
@@ -176,7 +175,7 @@ static ssize_t decode_value(TALLOC_CTX *ctx, fr_pair_list_t *out,
                break;
 
        case FR_TYPE_STRUCT:
-               slen = fr_struct_from_network(ctx, out, parent, data, data_len, packet_ctx->struct_nested,
+               slen = fr_struct_from_network(ctx, out, parent, data, data_len, false,
                                              decode_ctx, decode_value_trampoline, decode_tlv_trampoline);
                if (slen < 0) goto raw;
 

diff --git a/src/protocols/dhcpv6/dhcpv6.h b/src/protocols/dhcpv6/dhcpv6.h
index cce442f2b821dca855a6a92055ad80b7d920826a..2b880655f07d7f8a7c3d8ca79b2be17c1f177c46 100644 (file)
--- a/src/protocols/dhcpv6/dhcpv6.h
+++ b/src/protocols/dhcpv6/dhcpv6.h
@@ -142,7 +142,6 @@ typedef struct {
        uint32_t                transaction_id;         //!< previous transaction ID
        uint8_t                 *duid;                  //!< the expected DUID, in wire format
        size_t                  duid_len;               //!< length of the expected DUID
-       bool                    struct_nested;          //!< decode structs as nested
 } fr_dhcpv6_decode_ctx_t;
 
 /*