]> git.ipfire.org Git - thirdparty/postfix.git/commitdiff
postfix-2.4.2-RC2 v2.4.2-RC2
authorWietse Venema <wietse@porcupine.org>
Thu, 24 May 2007 05:00:00 +0000 (00:00 -0500)
committerViktor Dukhovni <postfix-users@dukhovni.org>
Sat, 10 Feb 2018 20:13:44 +0000 (15:13 -0500)
postfix/HISTORY
postfix/html/error.8.html
postfix/src/cleanup/cleanup_out_recipient.c
postfix/src/discard/discard.c
postfix/src/error/error.c
postfix/src/global/mail_version.h
postfix/src/local/mailbox.c
postfix/src/local/unknown.c

index 4009c60afecb0c9740bb47772284adad4af5b55c..65bb6baf822ad7ce321f54ca6e707cb33ceeff4e 100644 (file)
@@ -13447,3 +13447,17 @@ Apologies for any names omitted.
 
        Bugfix: Content-Transfer-Encoding: attribute values are
        case insensitive. File: src/cleanup/cleanup_message.c.
+
+20070514
+
+       Bugfix: mailbox_transport(_maps) and fallback_transport(_maps)
+       were broken when used with the error(8) or discard(8)
+       transports. Cause: insufficient documentation.  Files:
+       error/error.c, discard/discard.c.
+
+20070520
+
+       Bugfix (problem introduced Postfix 2.3): when DSN support
+       was introduced it broke "agressive" recipient duplicate
+       elimination with "enable_original_recipient = no".  File:
+       cleanup/cleanup_out_recipient.c.
index d66f9ead40b34ffd2a7e3dbc3219df3169b16938..c14495dc277f074fb7eb63f14d03a15f8d514754 100644 (file)
@@ -17,8 +17,8 @@ ERROR(8)                                                              ERROR(8)
        requests from the queue manager. Each request specifies  a
        queue  file, a sender address, the reason for non-delivery
        (specified as the  next-hop  destination),  and  recipient
-       information.   The  reason  may  be  prefixed  with an RFC
-       3463-compatible detail code.  This program expects  to  be
+       information.   The  reason  may  be  prefixed  with an <a href="http://www.faqs.org/rfcs/rfc3463.html">RFC</a>
+       <a href="http://www.faqs.org/rfcs/rfc3463.html">3463</a>-compatible detail code.  This program expects  to  be
        run from the <a href="master.8.html"><b>master</b>(8)</a> process manager.
 
        Depending  on  the  service  name  in  <a href="master.5.html">master.cf</a>, <b>error</b> or
index 476dc44b56271e0ab3adeff8bf497ab9ecda44cd..25ffb90526cad0077feaa0e7dc47c95ef87c6953 100644 (file)
@@ -127,13 +127,20 @@ void    cleanup_out_recipient(CLEANUP_STATE *state,
      * Distinguish between different original recipient addresses that map
      * onto the same mailbox. The recipient will use our original recipient
      * message header to figure things out.
+     * 
+     * Postfix 2.2 compatibility: when ignoring differences in Postfix original
+     * recipient information, also ignore differences in DSN attributes. We
+     * do, however, keep the DSN attributes of the recipient that survives
+     * duplicate elimination.
      */
 #define STREQ(x, y) (strcmp((x), (y)) == 0)
 
     if ((state->flags & CLEANUP_FLAG_MAP_OK) == 0
        || cleanup_virt_alias_maps == 0) {
-       if (been_here(state->dups, "%s\n%d\n%s\n%s",
-                     dsn_orcpt, dsn_notify, orcpt, recip) == 0) {
+       if ((var_enable_orcpt ?
+            been_here(state->dups, "%s\n%d\n%s\n%s",
+                      dsn_orcpt, dsn_notify, orcpt, recip) :
+            been_here_fixed(state->dups, recip)) == 0) {
            if (dsn_notify)
                cleanup_out_format(state, REC_TYPE_ATTR, "%s=%d",
                                   MAIL_ATTR_DSN_NOTIFY, dsn_notify);
@@ -181,6 +188,11 @@ void    cleanup_out_recipient(CLEANUP_STATE *state,
      * notifications. The queue manager will flush the trace (and bounce)
      * logfile, possibly after it has generated its own success or failure
      * notification records.
+     * 
+     * Postfix 2.2 compatibility: when ignoring differences in Postfix original
+     * recipient information, also ignore differences in DSN attributes. We
+     * do, however, keep the DSN attributes of the recipient that survives
+     * duplicate elimination.
      */
     else {
        RECIPIENT rcpt;
@@ -198,8 +210,10 @@ void    cleanup_out_recipient(CLEANUP_STATE *state,
                          dsn_notify & ~DSN_NOTIFY_SUCCESS);
        }
        for (cpp = argv->argv; *cpp; cpp++) {
-           if (been_here(state->dups, "%s\n%d\n%s\n%s",
-                         dsn_orcpt, dsn_notify, orcpt, *cpp) == 0) {
+           if ((var_enable_orcpt ?
+                been_here(state->dups, "%s\n%d\n%s\n%s",
+                          dsn_orcpt, dsn_notify, orcpt, *cpp) :
+                been_here_fixed(state->dups, *cpp)) == 0) {
                if (dsn_notify)
                    cleanup_out_format(state, REC_TYPE_ATTR, "%s=%d",
                                       MAIL_ATTR_DSN_NOTIFY, dsn_notify);
index 17bdeceeed49f3fd69231daccd186fbec8d9b55d..c0e5e6debac05a67a4522bf9b9ef18573a95da82 100644 (file)
@@ -174,13 +174,11 @@ static int deliver_message(DELIVER_REQUEST *request)
     (void) DSN_SIMPLE(&dsn, DSN_STATUS(dp.dsn), dp.text);
     for (nrcpt = 0; nrcpt < request->rcpt_list.len; nrcpt++) {
        rcpt = request->rcpt_list.info + nrcpt;
-       if (rcpt->offset >= 0) {
-           status = sent(BOUNCE_FLAGS(request), request->queue_id,
-                         &request->msg_stats, rcpt, "none", &dsn);
-           if (status == 0 && (request->flags & DEL_REQ_FLAG_SUCCESS))
-               deliver_completed(src, rcpt->offset);
-           result |= status;
-       }
+       status = sent(BOUNCE_FLAGS(request), request->queue_id,
+                     &request->msg_stats, rcpt, "none", &dsn);
+       if (status == 0 && (request->flags & DEL_REQ_FLAG_SUCCESS))
+           deliver_completed(src, rcpt->offset);
+       result |= status;
     }
 
     /*
index 019900b2b957624099b05ce74812c45142446fe6..73777cd101d8a46fa76a994da69cc1854d723bb3 100644 (file)
@@ -181,13 +181,11 @@ static int deliver_message(DELIVER_REQUEST *request, const char *def_dsn,
     (void) DSN_SIMPLE(&dsn, DSN_STATUS(dp.dsn), dp.text);
     for (nrcpt = 0; nrcpt < request->rcpt_list.len; nrcpt++) {
        rcpt = request->rcpt_list.info + nrcpt;
-       if (rcpt->offset >= 0) {
-           status = append(BOUNCE_FLAGS(request), request->queue_id,
-                           &request->msg_stats, rcpt, "none", &dsn);
-           if (status == 0)
-               deliver_completed(src, rcpt->offset);
-           result |= status;
-       }
+       status = append(BOUNCE_FLAGS(request), request->queue_id,
+                       &request->msg_stats, rcpt, "none", &dsn);
+       if (status == 0)
+           deliver_completed(src, rcpt->offset);
+       result |= status;
     }
 
     /*
index c1c19242f0e4bfc0ec03f86d715e451b2cb46b4f..a46b605bcdfb5ae82893a10f315504c9d0678177 100644 (file)
@@ -20,8 +20,8 @@
   * Patches change both the patchlevel and the release date. Snapshots have no
   * patchlevel; they change the release date only.
   */
-#define MAIL_RELEASE_DATE      "20070511"
-#define MAIL_VERSION_NUMBER    "2.4.2-RC1"
+#define MAIL_RELEASE_DATE      "20070524"
+#define MAIL_VERSION_NUMBER    "2.4.2-RC2"
 
 #ifdef SNAPSHOT
 # define MAIL_VERSION_DATE     "-" MAIL_RELEASE_DATE
index 04cead1b90cbd09e009727a3dcdc3a5e5d4470ed..92bd79d6767c28b518b3417e77e0fa434690faa5 100644 (file)
@@ -271,6 +271,7 @@ int     deliver_mailbox(LOCAL_STATE state, USER_ATTR usr_attr, int *statusp)
     if (*var_mbox_transp_maps && transp_maps == 0)
        transp_maps = maps_create(VAR_MBOX_TRANSP_MAPS, var_mbox_transp_maps,
                                  DICT_FLAG_LOCK | DICT_FLAG_NO_REGSUB);
+    /* The -1 is a hint for the down-stream deliver_completed() function. */
     if (*var_mbox_transp_maps
        && (map_transport = maps_find(transp_maps, state.msg_attr.user,
                                      DICT_FLAG_NONE)) != 0) {
index cc80acfa6aaf798caa1435d918289ec6f13837ea..068f9eed2683ca44e59e069861112e9a2e5c42e8 100644 (file)
@@ -109,9 +109,11 @@ int     deliver_unknown(LOCAL_STATE state, USER_ATTR usr_attr)
     if (*var_fbck_transp_maps && transp_maps == 0)
        transp_maps = maps_create(VAR_FBCK_TRANSP_MAPS, var_fbck_transp_maps,
                                  DICT_FLAG_LOCK | DICT_FLAG_NO_REGSUB);
+    /* The -1 is a hint for the down-stream deliver_completed() function. */
     if (*var_fbck_transp_maps
        && (map_transport = maps_find(transp_maps, state.msg_attr.user,
                                      DICT_FLAG_NONE)) != 0) {
+       state.msg_attr.rcpt.offset = -1L;
        return (deliver_pass(MAIL_CLASS_PRIVATE, map_transport,
                             state.request, &state.msg_attr.rcpt));
     }