]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
ctdb-tools: Remove simple uses of strcpy(3)
authorMartin Schwenke <martin@meltin.net>
Fri, 15 Apr 2016 04:52:45 +0000 (14:52 +1000)
committerAmitay Isaacs <amitay@samba.org>
Sun, 17 Apr 2016 15:37:06 +0000 (17:37 +0200)
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Sun Apr 17 17:37:06 CEST 2016 on sn-devel-144

ctdb/tools/ctdb.c

index 84d8132fdcc6f5a7b9ef851db3db3c94cad7adb1..7305aa4be543986974ae3b3768a739248ef88c84 100644 (file)
@@ -92,7 +92,7 @@ static int printm(const char *format, ...)
        size_t len = strlen(format);
        char new_format[len+1];
 
-       strcpy(new_format, format);
+       strncpy(new_format, format, len+1);
 
        if (options.machineseparator[0] != ':') {
                all_string_sub(new_format,
@@ -2718,7 +2718,8 @@ static int control_setifacelink(struct ctdb_context *ctdb, int argc, const char
                talloc_free(tmp_ctx);
                return -1;
        }
-       strcpy(info.name, argv[0]);
+       strncpy(info.name, argv[0], sizeof(info.name)-1);
+       info.name[sizeof(info.name)-1] = '\0';
 
        if (strcmp(argv[1], "up") == 0) {
                info.link_state = 1;