spi: geni-qcom: Improve target mode allocation by using proper allocation functions

The current implementation always allocates a host controller and sets the
target flag later when the "spi-slave" device tree property is present.
This approach is suboptimal as it doesn't utilize the dedicated allocation
functions designed for target mode.

Use devm_spi_alloc_target() when "spi-slave" device tree property is
present, otherwise use devm_spi_alloc_host(). This replaces the previous
approach of always allocating a host controller and setting target flag
later.

Signed-off-by: Praveen Talari <praveen.talari@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://patch.msgid.link/20260204162854.1206323-2-praveen.talari@oss.qualcomm.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c
index 0e5fd9df1a8f50db4b62f182c1d37fdd075a0668..f886a9ba56e6e0d74982489fcac0a674aff47c9d 100644 (file)
--- a/drivers/spi/spi-geni-qcom.c
+++ b/drivers/spi/spi-geni-qcom.c
@@ -1033,7 +1033,11 @@ static int spi_geni_probe(struct platform_device *pdev)
        if (IS_ERR(clk))
                return PTR_ERR(clk);
 
-       spi = devm_spi_alloc_host(dev, sizeof(*mas));
+       if (device_property_read_bool(dev, "spi-slave"))
+               spi = devm_spi_alloc_target(dev, sizeof(*mas));
+       else
+               spi = devm_spi_alloc_host(dev, sizeof(*mas));
+
        if (!spi)
                return -ENOMEM;
 
@@ -1087,9 +1091,6 @@ static int spi_geni_probe(struct platform_device *pdev)
        if (ret)
                return ret;
 
-       if (device_property_read_bool(&pdev->dev, "spi-slave"))
-               spi->target = true;
-
        /* Set the bus quota to a reasonable value for register access */
        mas->se.icc_paths[GENI_TO_CORE].avg_bw = Bps_to_icc(CORE_2X_50_MHZ);
        mas->se.icc_paths[CPU_TO_GENI].avg_bw = GENI_DEFAULT_BW;