codegen: Don't use G_GNUC_INTERNAL on implicit type specific fields

The actual field was never handled that way, so don't apply it at all
when --hide-internal is passed.

Introduced by 970f58989a2863faca11e30fdbcf4da1273a6acd which claimed to
apply it to methods only.

Fixes https://gitlab.gnome.org/GNOME/vala/issues/1178

diff --git a/codegen/valaccodebasemodule.vala b/codegen/valaccodebasemodule.vala
index cf12c4ecde0c4ac98f14d4b88c701a04c538c613..34963707ddb16867f5d75a68565981be9fd46435 100644 (file)
--- a/codegen/valaccodebasemodule.vala
+++ b/codegen/valaccodebasemodule.vala
@@ -1165,8 +1165,6 @@ public abstract class Vala.CCodeBaseModule : CodeGenerator {
 
                        if (f.is_private_symbol ()) {
                                flock.modifiers = CCodeModifiers.STATIC;
-                       } else if (context.hide_internal && f.is_internal_symbol ()) {
-                               flock.modifiers = CCodeModifiers.INTERNAL;
                        } else {
                                flock.modifiers = CCodeModifiers.EXTERN;
                        }
@@ -1184,8 +1182,6 @@ public abstract class Vala.CCodeBaseModule : CodeGenerator {
                                        cdecl.add_declarator (new CCodeVariableDeclarator (get_variable_array_length_cname (f, dim)));
                                        if (f.is_private_symbol ()) {
                                                cdecl.modifiers = CCodeModifiers.STATIC;
-                                       } else if (context.hide_internal && f.is_internal_symbol ()) {
-                                               cdecl.modifiers = CCodeModifiers.INTERNAL;
                                        } else {
                                                cdecl.modifiers = CCodeModifiers.EXTERN;
                                        }
@@ -1201,8 +1197,6 @@ public abstract class Vala.CCodeBaseModule : CodeGenerator {
                                cdecl.add_declarator (new CCodeVariableDeclarator (get_ccode_delegate_target_name (f)));
                                if (f.is_private_symbol ()) {
                                        cdecl.modifiers = CCodeModifiers.STATIC;
-                               } else if (context.hide_internal && f.is_internal_symbol ()) {
-                                       cdecl.modifiers = CCodeModifiers.INTERNAL;
                                } else {
                                        cdecl.modifiers = CCodeModifiers.EXTERN;
                                }
@@ -1213,8 +1207,6 @@ public abstract class Vala.CCodeBaseModule : CodeGenerator {
                                        cdecl.add_declarator (new CCodeVariableDeclarator (get_ccode_delegate_target_destroy_notify_name (f)));
                                        if (f.is_private_symbol ()) {
                                                cdecl.modifiers = CCodeModifiers.STATIC;
-                                       } else if (context.hide_internal && f.is_internal_symbol ()) {
-                                               cdecl.modifiers = CCodeModifiers.INTERNAL;
                                        } else {
                                                cdecl.modifiers = CCodeModifiers.EXTERN;
                                        }