]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
netfilter: nf_tables: skip netlink portID validation if zero
authorPablo Neira Ayuso <pablo@netfilter.org>
Tue, 22 Jun 2021 09:45:11 +0000 (11:45 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Jul 2021 14:59:58 +0000 (16:59 +0200)
[ Upstream commit 534799097a777e82910f77a4f9d289c815a9a64e ]

nft_table_lookup() allows us to obtain the table object by the name and
the family. The netlink portID validation needs to be skipped for the
dump path, since the ownership only applies to commands to update the
given table. Skip validation if the specified netlink PortID is zero
when calling nft_table_lookup().

Fixes: 6001a930ce03 ("netfilter: nftables: introduce table ownership")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/netfilter/nf_tables_api.c

index 9d5ea235296578c9bc249464afd4abb72583108f..3705086d43f500cfe44ba89450ab059585cae1f2 100644 (file)
@@ -521,7 +521,7 @@ static struct nft_table *nft_table_lookup(const struct net *net,
                    table->family == family &&
                    nft_active_genmask(table, genmask)) {
                        if (nft_table_has_owner(table) &&
-                           table->nlpid != nlpid)
+                           nlpid && table->nlpid != nlpid)
                                return ERR_PTR(-EPERM);
 
                        return table;