r19312: This should fix a nasty bug with values and names being freed before the...

Seem that el is hanging out of a request, and the target is put on the final results.

Still one to catch and fix, but this seem to cure most of them
(This used to be commit bfeaa08fde805439dbda974be6fcb692957b00f1)

diff --git a/source4/lib/ldb/modules/ldb_map_outbound.c b/source4/lib/ldb/modules/ldb_map_outbound.c
index e1b207f6eb985008675155ff9b05a41e95efcbf5..02876eea552b1a97b86712e130e62ae5b9225e18 100644 (file)
--- a/source4/lib/ldb/modules/ldb_map_outbound.c
+++ b/source4/lib/ldb/modules/ldb_map_outbound.c
@@ -202,7 +202,11 @@ static int ldb_msg_replace(struct ldb_message *msg, const struct ldb_message_ele
                }
        }
 
-       *old = *el;                     /* copy new element */
+       /* copy new element */
+       *old = *el;
+       /* and make sure we reference the contents */
+       talloc_reference(msg->elements, el->name);
+       talloc_reference(msg->elements, el->values);
 
        return 0;
 }