wifi: mt76: Drop unneeded mt76_register_debugfs_fops() return checks

mt76_register_debugfs_fops() returns the dentry from
debugfs_create_dir(), which yields an error pointer on failure
(notably ERR_PTR(-ENODEV) when CONFIG_DEBUG_FS=n), never NULL. Per
commit ff9fb72bc077 ("debugfs: return error values, not NULL"),
callers do not need to check the return value.

Drop the dead !dir checks in mt7615/mt7915/mt7921/mt7925/mt7996
_init_debugfs(). Converting them to IS_ERR() instead would have
exposed a probe abort on CONFIG_DEBUG_FS=n, since each
*_init_debugfs() caller propagates the helper's return value.

This patch supersedes an earlier proposal that converted the checks
to IS_ERR().

Link: https://lore.kernel.org/all/20260514193243.2518979-1-ingyujang25@korea.ac.kr
Signed-off-by: Ingyu Jang <ingyujang25@korea.ac.kr>
Link: https://patch.msgid.link/20260519085214.164846-1-ingyujang25@korea.ac.kr
Signed-off-by: Felix Fietkau <nbd@nbd.name>

diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/debugfs.c b/drivers/net/wireless/mediatek/mt76/mt7615/debugfs.c
index 0f7b20152279c3121b3d9a1d70d0751d7986f6e2..6a1475e3c89993990bb9ff52356ff47b2958782d 100644 (file)
--- a/drivers/net/wireless/mediatek/mt76/mt7615/debugfs.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/debugfs.c
@@ -550,8 +550,6 @@ int mt7615_init_debugfs(struct mt7615_dev *dev)
        struct dentry *dir;
 
        dir = mt76_register_debugfs_fops(&dev->mphy, &fops_regval);
-       if (!dir)
-               return -ENOMEM;
 
        if (is_mt7615(&dev->mt76))
                debugfs_create_devm_seqfile(dev->mt76.dev, "xmit-queues", dir,

diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c b/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c
index 26ed3745af43ee64ea20d1a5b0a3cf49243c21c2..4d0854fe785bd86e90441ec46c9df6fc4d784f70 100644 (file)
--- a/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c
@@ -1296,8 +1296,7 @@ int mt7915_init_debugfs(struct mt7915_phy *phy)
        struct dentry *dir;
 
        dir = mt76_register_debugfs_fops(phy->mt76, NULL);
-       if (!dir)
-               return -ENOMEM;
+
        debugfs_create_file("muru_debug", 0600, dir, dev, &fops_muru_debug);
        debugfs_create_file("muru_stats", 0400, dir, phy,
                            &mt7915_muru_stats_fops);

diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c b/drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c
index 4333005b3ad95c320858224a55d7f5adb909e4fb..a5a70d8e8544a56315255aa2ee5bd2e580ea4280 100644 (file)
--- a/drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c
@@ -266,8 +266,6 @@ int mt7921_init_debugfs(struct mt792x_dev *dev)
        struct dentry *dir;
 
        dir = mt76_register_debugfs_fops(&dev->mphy, &fops_regval);
-       if (!dir)
-               return -ENOMEM;
 
        if (mt76_is_mmio(&dev->mt76))
                debugfs_create_devm_seqfile(dev->mt76.dev, "xmit-queues",

diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/debugfs.c b/drivers/net/wireless/mediatek/mt76/mt7925/debugfs.c
index e2498659c884e35cb725f45d741862e6b47ec1b6..d01ff49de47af7b9163dbd634ab05cf478f244ee 100644 (file)
--- a/drivers/net/wireless/mediatek/mt76/mt7925/debugfs.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7925/debugfs.c
@@ -291,8 +291,6 @@ int mt7925_init_debugfs(struct mt792x_dev *dev)
        struct dentry *dir;
 
        dir = mt76_register_debugfs_fops(&dev->mphy, &fops_regval);
-       if (!dir)
-               return -ENOMEM;
 
        if (mt76_is_mmio(&dev->mt76))
                debugfs_create_devm_seqfile(dev->mt76.dev, "xmit-queues",

diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/debugfs.c b/drivers/net/wireless/mediatek/mt76/mt7996/debugfs.c
index ef9a9204adf5999e9c5fa22adba86b3f43ecc9d9..b85c3e549f8b9130c9525e8c84c5d74e4f246ee4 100644 (file)
--- a/drivers/net/wireless/mediatek/mt76/mt7996/debugfs.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7996/debugfs.c
@@ -875,8 +875,6 @@ int mt7996_init_debugfs(struct mt7996_dev *dev)
        struct dentry *dir;
 
        dir = mt76_register_debugfs_fops(&dev->mphy, NULL);
-       if (!dir)
-               return -ENOMEM;
 
        debugfs_create_file("hw-queues", 0400, dir, dev,
                            &mt7996_hw_queues_fops);