]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ASoC: tegra: Add error logging in tegra210_adx driver
authorSheetal <sheetal@nvidia.com>
Wed, 25 Mar 2026 10:14:27 +0000 (10:14 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 25 Mar 2026 13:14:20 +0000 (13:14 +0000)
Log errors in the Tegra210 ADX probe and set_audio_cif paths.

Signed-off-by: Sheetal <sheetal@nvidia.com>
Link: https://patch.msgid.link/20260325101437.3059693-5-sheetal@nvidia.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/tegra/tegra210_adx.c

index 95875c75ddf87d51867a6adffc6a925f6c6c7b75..6a5f93f76984b0a6e25ccc5085f5065ee926804f 100644 (file)
@@ -134,8 +134,11 @@ static int tegra210_adx_set_audio_cif(struct snd_soc_dai *dai,
 
        memset(&cif_conf, 0, sizeof(struct tegra_cif_conf));
 
-       if (channels < 1 || channels > adx->soc_data->max_ch)
+       if (channels < 1 || channels > adx->soc_data->max_ch) {
+               dev_err(dai->dev, "invalid channels: %u (max %u)\n",
+                       channels, adx->soc_data->max_ch);
                return -EINVAL;
+       }
 
        switch (format) {
        case SNDRV_PCM_FORMAT_S8:
@@ -149,6 +152,7 @@ static int tegra210_adx_set_audio_cif(struct snd_soc_dai *dai,
                audio_bits = TEGRA_ACIF_BITS_32;
                break;
        default:
+               dev_err(dai->dev, "unsupported format: %d\n", format);
                return -EINVAL;
        }
 
@@ -717,10 +721,9 @@ static int tegra210_adx_platform_probe(struct platform_device *pdev)
        err = devm_snd_soc_register_component(dev, &tegra210_adx_cmpnt,
                                              tegra210_adx_dais,
                                              ARRAY_SIZE(tegra210_adx_dais));
-       if (err) {
-               dev_err(dev, "can't register ADX component, err: %d\n", err);
-               return err;
-       }
+       if (err)
+               return dev_err_probe(dev, err,
+                                    "can't register ADX component\n");
 
        pm_runtime_enable(dev);