]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core.git/commitdiff
quilt: Fix merge.test race condition
authorKhem Raj <raj.khem@gmail.com>
Tue, 25 Apr 2023 05:27:41 +0000 (22:27 -0700)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 5 May 2023 09:57:08 +0000 (10:57 +0100)
This is consistently seen with musl and grep from busybox
Therefore backport a patch from upstream to fix it

Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-devtools/quilt/quilt.inc
meta/recipes-devtools/quilt/quilt/0001-test-Fix-a-race-condition-in-merge.test.patch [new file with mode: 0644]

index c93c38b83ca4b660f4d93fd4d432aa5390b2b343..3374f4dfbf35f17cc7fa4c16c10cf26487bd8c6f 100644 (file)
@@ -13,6 +13,7 @@ SRC_URI = "${SAVANNAH_GNU_MIRROR}/quilt/quilt-${PV}.tar.gz \
         file://0001-tests-Allow-different-output-from-mv.patch \
         file://fix-grep-3.8.patch \
         file://faildiff-order.patch \
+        file://0001-test-Fix-a-race-condition-in-merge.test.patch \
 "
 
 SRC_URI:append:class-target = " file://gnu_patch_test_fix_target.patch"
diff --git a/meta/recipes-devtools/quilt/quilt/0001-test-Fix-a-race-condition-in-merge.test.patch b/meta/recipes-devtools/quilt/quilt/0001-test-Fix-a-race-condition-in-merge.test.patch
new file mode 100644 (file)
index 0000000..01d4c8b
--- /dev/null
@@ -0,0 +1,48 @@
+From c1ce964f3e9312100a60f03c1e1fdd601e1911f2 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
+ <congdanhqx@gmail.com>
+Date: Tue, 28 Feb 2023 18:45:15 +0100
+Subject: [PATCH] test: Fix a race condition in merge.test
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Just like commit 4dfe7f9, (test: Fix a race condition, 2023-01-20),
+this fix a test race when stdout and stderr in any order.
+
+Upstream-Status: Backport [https://git.savannah.nongnu.org/cgit/quilt.git/commit/?id=c1ce964f3e9312100a60f03c1e1fdd601e1911f2]
+Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>
+Signed-off-by: Jean Delvare <jdelvare@suse.de>
+---
+ test/merge.test | 6 ++++--
+ 1 file changed, 4 insertions(+), 2 deletions(-)
+
+diff --git a/test/merge.test b/test/merge.test
+index c64b33d..2e67d4f 100644
+--- a/test/merge.test
++++ b/test/merge.test
+@@ -39,8 +39,9 @@ Test the patch merging functionality of `quilt diff'.
+       > Applying patch %{P}c.diff
+       > Now at patch %{P}c.diff
+-      $ quilt diff -P b.diff | grep -v "^\\(---\\|+++\\)"
++      $ quilt diff -P b.diff >/dev/null
+       > Warning: more recent patches modify files in patch %{P}b.diff
++      $ quilt diff -P b.diff 2>/dev/null | grep -v "^\\(---\\|+++\\)"
+       >~ Index: [^/]+/abc\.txt
+       > ===================================================================
+       > @@ -1,3 +1,3 @@
+@@ -49,8 +50,9 @@ Test the patch merging functionality of `quilt diff'.
+       > +b+
+       >  c
+-      $ quilt diff --combine a.diff -P b.diff | grep -v "^\\(---\\|+++\\)"
++      $ quilt diff --combine a.diff -P b.diff >/dev/null
+       > Warning: more recent patches modify files in patch %{P}b.diff
++      $ quilt diff --combine a.diff -P b.diff 2>/dev/null | grep -v "^\\(---\\|+++\\)"
+       >~ Index: [^/]+/abc\.txt
+       > ===================================================================
+       > @@ -1,3 +1,3 @@
+-- 
+2.40.0
+