eve/flow: turn error into debug assertion

In case this hits logging an error is harmful, better to silently
continue.

Remove use of `default` to help the compiler flag new enum additions.

diff --git a/src/output-json-flow.c b/src/output-json-flow.c
index 14f62aa0040159e64adf27e7ee62b66e4e207aa5..8172d26d37b437686e58b21a20e01a21357978e4 100644 (file)
--- a/src/output-json-flow.c
+++ b/src/output-json-flow.c
@@ -252,8 +252,9 @@ static void EveFlowLogJSON(OutputJsonThreadCtx *aft, JsonBuilder *jb, Flow *f)
             JB_SET_STRING(jb, "bypass", "capture");
             break;
 #endif
-        default:
-            SCLogError("Invalid flow state: %d, contact developers", flow_state);
+        case FLOW_STATE_SIZE:
+            DEBUG_VALIDATE_BUG_ON(1);
+            SCLogDebug("invalid flow state: %d, contact developers", flow_state);
     }
 
     const char *reason = NULL;