]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ata: libata-eh: Make ata_eh_followup_srst_needed() return a bool
authorDamien Le Moal <dlemoal@kernel.org>
Fri, 11 Jul 2025 08:21:58 +0000 (17:21 +0900)
committerNiklas Cassel <cassel@kernel.org>
Fri, 11 Jul 2025 08:32:51 +0000 (10:32 +0200)
ata_eh_followup_srst_needed() returns an integer used as a boolean. So
change this function to return that type.

No functional changes.

Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Niklas Cassel <cassel@kernel.org>
Link: https://lore.kernel.org/r/20250711082158.220047-1-dlemoal@kernel.org
Signed-off-by: Niklas Cassel <cassel@kernel.org>
drivers/ata/libata-eh.c

index 42aafb1ddb5a17381c2a828a79198b772d462eed..436536112043ce6adbc697e573118e38db269b97 100644 (file)
@@ -2781,15 +2781,15 @@ static int ata_do_reset(struct ata_link *link, ata_reset_fn_t reset,
        return reset(link, classes, deadline);
 }
 
-static int ata_eh_followup_srst_needed(struct ata_link *link, int rc)
+static bool ata_eh_followup_srst_needed(struct ata_link *link, int rc)
 {
        if ((link->flags & ATA_LFLAG_NO_SRST) || ata_link_offline(link))
-               return 0;
+               return false;
        if (rc == -EAGAIN)
-               return 1;
+               return true;
        if (sata_pmp_supported(link->ap) && ata_is_host_link(link))
-               return 1;
-       return 0;
+               return true;
+       return false;
 }
 
 int ata_eh_reset(struct ata_link *link, int classify,