Bug 255664: Wait until buglist is ready to be displayed before closing the "please...

r=myk, a=myk

diff --git a/buglist.cgi b/buglist.cgi
index 1e71d5238ee14b09f4856e0bd06842fd4ba5146d..cfdb8b4065520f16dbea15c64c6c1289cce72246 100755 (executable)
--- a/buglist.cgi
+++ b/buglist.cgi
@@ -729,7 +729,9 @@ if ($serverpush) {
     $template->process("list/server-push.html.tmpl", $vars)
       || ThrowTemplateError($template->error());
 
-    print $cgi->multipart_end();
+    # Don't do multipart_end() until we're ready to display the replacement
+    # page, otherwise any errors that happen before then (like SQL errors)
+    # will result in a blank page being shown to the user instead of the error.
 }
 
 # Connect to the shadow database if this installation is using one to improve
@@ -954,6 +956,8 @@ if ($format->{'extension'} eq "csv") {
 }
 
 if ($serverpush) {
+    # close the "please wait" page, then open the buglist page
+    print $cgi->multipart_end();
     print $cgi->multipart_start(-type=>$contenttype);
 } else {
     # Suggest a name for the bug list if the user wants to save it as a file.