]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
test: fix coverity 1454812: improper use of negative value
authorPauli <ppzgs1@gmail.com>
Mon, 22 Mar 2021 02:33:32 +0000 (12:33 +1000)
committerPauli <ppzgs1@gmail.com>
Tue, 23 Mar 2021 23:12:43 +0000 (09:12 +1000)
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14638)

test/clienthellotest.c

index 6d7fb499657ca5280209f5b9cfa52c3feced5d40..04ff4184ae24df4b36518c91a6db73ceb08121df 100644 (file)
@@ -185,8 +185,8 @@ static int test_client_hello(int currtest)
         goto end;
     }
 
-    len = BIO_get_mem_data(wbio, (char **)&data);
-    if (!TEST_true(PACKET_buf_init(&pkt, data, len))
+    if (!TEST_long_ge(len = BIO_get_mem_data(wbio, (char **)&data), 0)
+            || !TEST_true(PACKET_buf_init(&pkt, data, len))
                /* Skip the record header */
             || !PACKET_forward(&pkt, SSL3_RT_HEADER_LENGTH))
         goto end;