]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
i2c: designware: Remove an unnecessary condition
authorHeikki Krogerus <heikki.krogerus@linux.intel.com>
Tue, 20 Jan 2026 13:07:28 +0000 (14:07 +0100)
committerAndi Shyti <andi.shyti@kernel.org>
Thu, 22 Jan 2026 13:43:57 +0000 (14:43 +0100)
Writing also the high speed timing registers unconditionally.
The reset value for these registers is 0, so this should
always be safe.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20260120130729.1679560-5-heikki.krogerus@linux.intel.com
drivers/i2c/busses/i2c-designware-common.c

index 53d9337db5e2197648b7d19b7c44d06e2f1b04a4..64654dabbb210cb59484b7cda188064abb55df3b 100644 (file)
@@ -392,11 +392,9 @@ static void i2c_dw_write_timings(struct dw_i2c_dev *dev)
        regmap_write(dev->map, DW_IC_FS_SCL_HCNT, dev->fs_hcnt);
        regmap_write(dev->map, DW_IC_FS_SCL_LCNT, dev->fs_lcnt);
 
-       /* Write high speed timing parameters if supported */
-       if (dev->hs_hcnt && dev->hs_lcnt) {
-               regmap_write(dev->map, DW_IC_HS_SCL_HCNT, dev->hs_hcnt);
-               regmap_write(dev->map, DW_IC_HS_SCL_LCNT, dev->hs_lcnt);
-       }
+       /* Write high speed timing parameters */
+       regmap_write(dev->map, DW_IC_HS_SCL_HCNT, dev->hs_hcnt);
+       regmap_write(dev->map, DW_IC_HS_SCL_LCNT, dev->hs_lcnt);
 }
 
 /**