insane: Optimise ERROR_QA/WARN_QA references in do_populate_sysroot

The new contains code can't inspect variable references in handle_error()
calls. Expand what is effectively a hardcoded reference anyway so the code
can optimise it.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass
index 6a84c4aa74dcd96c4e26eeec68b36319f6edbf10..a008f21c6ee8fc0bf18df464f49a3bb60559a12f 100644 (file)
--- a/meta/classes-global/insane.bbclass
+++ b/meta/classes-global/insane.bbclass
@@ -789,9 +789,8 @@ def qa_check_staged(path,d):
             if not skip_shebang_size:
                 errors = {}
                 package_qa_check_shebang_size(path, "", d, None, errors)
-                for e in errors:
-                    oe.qa.handle_error(e, errors[e], d)
-
+                if "shebang-size" in errors:
+                    oe.qa.handle_error("shebang-size", errors["shebang-size"], d)
 
 # Run all package-wide warnfuncs and errorfuncs
 def package_qa_package(warnfuncs, errorfuncs, package, d):