]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
node_device: remove unneeded cleanup labels
authorDaniel Henrique Barboza <danielhb413@gmail.com>
Mon, 21 Oct 2019 18:18:56 +0000 (15:18 -0300)
committerJán Tomko <jtomko@redhat.com>
Tue, 12 Nov 2019 16:54:01 +0000 (17:54 +0100)
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/node_device/node_device_driver.c
src/node_device/node_device_udev.c

index 148ae15fed032e567dfb39393a8260d9c8a64174..ebcc9696af4380633145749b865cd0ca53e934fd 100644 (file)
@@ -587,20 +587,15 @@ int
 nodeConnectNodeDeviceEventDeregisterAny(virConnectPtr conn,
                                         int callbackID)
 {
-    int ret = -1;
-
     if (virConnectNodeDeviceEventDeregisterAnyEnsureACL(conn) < 0)
-        goto cleanup;
+        return -1;
 
     if (virObjectEventStateDeregisterID(conn,
                                         driver->nodeDeviceEventState,
                                         callbackID, true) < 0)
-        goto cleanup;
-
-    ret = 0;
+        return -1;
 
- cleanup:
-    return ret;
+    return 0;
 }
 
 int
index 29cd0ea573f9c09b29484136af588ff16ff3d95a..fabd2ec45415d39f03e9449594ac5b52d88cbf5b 100644 (file)
@@ -1259,7 +1259,6 @@ udevSetParent(struct udev_device *device,
     const char *parent_sysfs_path = NULL;
     virNodeDeviceObjPtr obj = NULL;
     virNodeDeviceDefPtr objdef;
-    int ret = -1;
 
     parent_device = device;
     do {
@@ -1273,7 +1272,7 @@ udevSetParent(struct udev_device *device,
             virReportError(VIR_ERR_INTERNAL_ERROR,
                            _("Could not get syspath for parent of '%s'"),
                            udev_device_get_syspath(parent_device));
-            goto cleanup;
+            return -1;
         }
 
         if ((obj = virNodeDeviceObjListFindBySysfsPath(driver->devs,
@@ -1290,10 +1289,7 @@ udevSetParent(struct udev_device *device,
     if (!def->parent)
         def->parent = g_strdup("computer");
 
-    ret = 0;
-
- cleanup:
-    return ret;
+    return 0;
 }